Proper error handling in Hive Queries #4428
Conversation
|
Can we retest this ? Failed check has nothing to do with my patch. |
|
@john-bodley thanks |
|
ping @mistercrunch |
|
ping @john-bodley |
|
@betodealmeida @mistercrunch would you mind reviewing this PR given your experience with Hive? |
superset/db_engine_specs.py
Outdated
| state = cursor.poll() | ||
| if state.operationState == ttypes.TOperationState.ERROR_STATE: | ||
| raise Exception('Query error', state.errorMessage) | ||
| if cls.limit_method == LimitMethod.FETCH_MANY: |
There was a problem hiding this comment.
Let's call super here instead of repeating the code in the parent class
There was a problem hiding this comment.
Done.
Sorry for delay. I was on the vacations :)
Codecov Report
@@ Coverage Diff @@
## master #4428 +/- ##
=========================================
Coverage ? 77.48%
=========================================
Files ? 44
Lines ? 8716
Branches ? 0
=========================================
Hits ? 6754
Misses ? 1962
Partials ? 0
Continue to review full report at Codecov.
|
|
@mistercrunch |
|
I was trying to understand whether this conflicts with |
|
I'm using this code on production few months. So probable there is no conflict. |
* Proper error handling in Hive Queries * Change quotes * Trigger checks * Adding call to parent class * Small fix * Fix in method call
* Proper error handling in Hive Queries * Change quotes * Trigger checks * Adding call to parent class * Small fix * Fix in method call
* Proper error handling in Hive Queries * Change quotes * Trigger checks * Adding call to parent class * Small fix * Fix in method call
mistercrunch
added
🏷️ bot
Resolves: #4414
Fetch_many gives strange exception when hive query is in Error state.
So we're reading status to get proper error message before calling fetch_many