Remove double call to ConnectorRegistry.sources #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the double call didn't cause any adverse effects upon removal. If required, a comment motivating the double call should be added.
villebro
changed the title
|
good catch. LGTM |
mistercrunch
pushed a commit
that referenced
this pull request
Mar 11, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
Removing the double call didn't cause any adverse effects upon removal. If required, a comment motivating the double call should be added.
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
PRs and apache#4413 and apache#4448 contributed while implementing Superset at Aktia.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
Removing the double call didn't cause any adverse effects upon removal. If required, a comment motivating the double call should be added.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
PRs and apache#4413 and apache#4448 contributed while implementing Superset at Aktia.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the double call didn't cause any adverse effects upon removal. If required, a comment motivating the double call should be added.