Make instant controls store state in URL #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
betodealmeida
commented
Feb 17, 2018
| @@ -47,7 +47,6 @@ export default function chartReducer(charts = {}, action) { | |||
| chartUpdateEndTime: null, | |||
| chartUpdateStartTime: now(), | |||
| queryRequest: action.queryRequest, | |||
| latestQueryFormData: action.latestQueryFormData, | |||
There was a problem hiding this comment.
This is now done explicitly in updateQueryFormData.
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Add to history on instant control change * Update latestQueryFormData on render triggered * Add new message type * Update latestQueryFormData in UPDATE_QUERY_FORM_DATA
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Add to history on instant control change * Update latestQueryFormData on render triggered * Add new message type * Update latestQueryFormData in UPDATE_QUERY_FORM_DATA
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an instant control is changed the visualization is re-rendered, but the
form_dataparameter in the URL is not updated. This means that if someone copies the URL, or generates a short URL, it will not point to the current visualization.I created a new action
UPDATE_QUERY_FORM_DATAthat is called whenever a query is run, but also when an instant control changes. This way, the URL and short URL reflect the current visualization, and can be shared as expected.(This PR is 1 of 2 addressing #4379)