Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] address issue 4206 #4452

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Conversation

mistercrunch
Copy link
Member

closes #4206

@@ -279,6 +279,8 @@ def edit(self, pk):
__('Refresh column metadata'),
'fa-refresh')
def refresh(self, tables):
if not isinstance(tables, list):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: tables = [tables] if not isinstance(tables, list) else tables

@hughhhh
Copy link
Member

hughhhh commented Feb 19, 2018

🚢

@mistercrunch mistercrunch merged commit 177d7c0 into apache:master Feb 19, 2018
@mistercrunch mistercrunch deleted the fix_4206 branch February 19, 2018 17:56
mistercrunch added a commit that referenced this pull request Feb 22, 2018
closes 4206

(cherry picked from commit 177d7c0)
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🍒 0.23.0 🍒 0.23.1 🍒 0.23.2 🍒 0.23.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
closes 4206

(cherry picked from commit 177d7c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels v0.23 🍒 0.23.0 🍒 0.23.1 🍒 0.23.2 🍒 0.23.3 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table Metadata Refresh | TypeError: 'SqlaTable' object is not iterable
2 participants