New Landing Page v1.0 #4463
New Landing Page v1.0 #4463
Conversation
|
this is great, would love to see 'my dashboards' (created by the user) in a different tab or as part of favorites tab. |
|
@kkalyan Just updated the gif with the new design |
| <Col md={8}><h2>Datasources</h2></Col> | ||
| </Row> | ||
| <hr /> | ||
| {/* <ChartsTable search={this.state.search} /> */} |
There was a problem hiding this comment.
Why the empty placeholders? I'm thinking it's better to not have the empty tabs than having them.
| <DashboardTable search={this.state.search} /> | ||
| </Panel> | ||
| <Tabs defaultActiveKey={1} id="uncontrolled-tab-example"> | ||
| <Tab eventKey={1} title="Recently Viewed"> |
There was a problem hiding this comment.
Lots of free text that should be wrap for i18n as in t('Translate this')
superset/views/utils.py
Outdated
| from superset import db | ||
|
|
||
|
|
||
| def bootstrap_user_data(given_username=None): |
There was a problem hiding this comment.
given_username is confusing to me as it sounds like "Given Name" which means something else. It would be ok to receive username and to go username = username or g.user.username on the first line
superset/views/__init__.py
Outdated
| @@ -2,3 +2,4 @@ | |||
| from . import core # noqa | |||
| from . import sql_lab # noqa | |||
| from . import annotations # noqa | |||
| from . import utils # noqa | |||
There was a problem hiding this comment.
this necessary? shouldn't be since no views should be registered here
superset/views/utils.py
Outdated
| ) | ||
| roles = {} | ||
| permissions = defaultdict(set) | ||
| for role in user.roles: |
There was a problem hiding this comment.
For the welcome page you don't need all that in the payload, maybe this utility function should have a include_perms=False arg. Man I wish we had GraphQL instead of having to change the backend logic...
|
LGTM though the build is red :( |
* Updated welcome landing page * fixed test and linting * linting * addressing comments * fix test * fix test * remove unneeded var * add magic comments
* Updated welcome landing page * fixed test and linting * linting * addressing comments * fix test * fix test * remove unneeded var * add magic comments
mistercrunch
added
🏷️ bot
Updated Landing Page with new tabs 💯
Reference #4376