[FilterBox] Make filterbox localizable #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Feb 23, 2018
There was a problem hiding this comment.
Looks good, could you please updated the po files while you are at it?
https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md#translations
|
PO files for italian is already updated. Strings are translated according to the po file as per latest update to the language pack. Did you want that I update all the languages in Superset ? |
|
@raffas I don't think so, if I git grep "Select starting date" i don't find anything in translations/. We need to rerun the tooling to create updated messages.pot and *.po files for each language. |
…translated via babel-extract
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Make filterbox i18n * Change double-quote to single-quote in localization function t() to pass lint test * Updated .po file with italian translation. New strings generated and translated via babel-extract
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Make filterbox i18n * Change double-quote to single-quote in localization function t() to pass lint test * Updated .po file with italian translation. New strings generated and translated via babel-extract
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to localize the fields Since , Until and Apply in the visualization of FilterBox.
Localization is done using the t() function