[flake8] Adding flake8-coding #4477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: we should also run checks making sure we have the future imports, especially unicode literals. |
john-bodley
force-pushed
the
john-bodley-flake8-coding
branch
from
3701477
to
314ca47
Compare
xrmx
approved these changes
Feb 24, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try to further ensure unicode consistency between Python 2 and Python 3 this PR adds the
flake8-configcheck to ensure that every Python file includes:which ensures that it is encoded as UTF-8 in Python 2 (which is the default in Python 3) as opposed to ASCII.
This PR also removes all
u'...'references which are no longer required.to: @mistercrunch @xrmx