Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WiP] Cleanup & fix URL scheme for the explore view #4490

Merged
merged 2 commits into from
Feb 27, 2018
Merged

[WiP] Cleanup & fix URL scheme for the explore view #4490

merged 2 commits into from
Feb 27, 2018

Conversation

mistercrunch
Copy link
Member

Moving datasource_id and datasource_type to the form_data blob as opposed to the URL directory (info was redundant)

  • fix and unit tests around loading slice_id, and overriding form_data
  • backward compatibility for previous URL schemes

@graceguo-supercat
Copy link

graceguo-supercat commented Feb 27, 2018 •
edited
Loading

LGTM

@graceguo-supercat graceguo-supercat merged commit 83524f9 into apache:master Feb 27, 2018
@mistercrunch mistercrunch deleted the fix_urls branch February 28, 2018 05:34
@Pek1s Pek1s mentioned this pull request Mar 5, 2018
Closed
3 tasks
@graceguo-supercat graceguo-supercat mentioned this pull request Mar 7, 2018
Merged
@williaster williaster mentioned this pull request Mar 13, 2018
Merged
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
[WiP] Cleanup & fix URL scheme for the explore view (apache#4490)
3822dc8 
* Improve URLs

* Fix js tests
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
[WiP] Cleanup & fix URL scheme for the explore view (apache#4490)
6c33625 
* Improve URLs

* Fix js tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mistercrunch @graceguo-supercat