Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] let's not use 'date' as a col name #4555

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

mistercrunch
Copy link
Member

'date' is a reserved word in most database

'date' is a reserved word in most database
@codecov-io
Copy link

codecov-io commented Mar 7, 2018

Codecov Report

Merging #4555 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4555   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files         187      187           
  Lines       14780    14780           
  Branches     1083     1083           
=======================================
  Hits        10513    10513           
  Misses       4264     4264           
  Partials        3        3
Impacted Files Coverage Δ
superset/data/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e780e4...8065147. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think this is a somewhat good way of testing if column names are properly escaped by the SQLAlchemy connector. Did this cause any problems?

@mistercrunch
Copy link
Member Author

mistercrunch commented Mar 20, 2018

I agree about having it as a way to improve the tests and prevent regressions, though my immediate urge was to fix the examples that were broken in MySQL.

In that spirit we do have a unicode-filled dataset in there, we should probably add a new dataset with reserved words as columns, table names and unicode-ridden column names and such.

Let's fix the examples for now and open an issue to address unicode and reserved words support as a task.

@mistercrunch mistercrunch merged commit 8942436 into apache:master Mar 20, 2018
@mistercrunch mistercrunch deleted the date_is_reserverd branch March 20, 2018 05:15
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
'date' is a reserved word in most database
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
'date' is a reserved word in most database
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants