[sqllab] Added share button to bottom menu #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4584 +/- ##
==========================================
+ Coverage 71.17% 71.19% +0.01%
==========================================
Files 187 188 +1
Lines 14809 14822 +13
Branches 1085 1085
==========================================
+ Hits 10540 10552 +12
- Misses 4266 4267 +1
Partials 3 3
Continue to review full report at Codecov.
|
mistercrunch
reviewed
Mar 9, 2018
| @@ -195,6 +196,11 @@ class SqlEditor extends React.PureComponent { | |||
| dbId={qe.dbId} | |||
| /> | |||
| </span> | |||
| <span className="m-r-5"> | |||
| <ShareQuery | |||
There was a problem hiding this comment.
nit: would fit nicely on a single line
|
LGTM, feel free to ship as is despite the minor nit |
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 9, 2018
* added sharebtn * address comments (cherry picked from commit c6af488)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* added sharebtn * address comments
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* added sharebtn * address comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added share button to sqllab bottom menu for easier discoverability