Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Resizing widgets problem #4596 #4597

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

oxydash
Copy link
Contributor

@oxydash oxydash commented Mar 11, 2018

react-grid-layout 0.16.6 causes an issue with resizing the widget. See more ... #4596.

@codecov-io
Copy link

codecov-io commented Mar 11, 2018

Codecov Report

Merging #4597 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4597   +/-   ##
=======================================
  Coverage   71.17%   71.17%           
=======================================
  Files         188      188           
  Lines       14834    14834           
  Branches     1086     1086           
=======================================
  Hits        10558    10558           
  Misses       4273     4273           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee073ee...85f6ea3. Read the comment docs.

@@ -89,7 +89,7 @@
"react-datetime": "2.9.0",
"react-dom": "^15.6.2",
"react-gravatar": "^2.6.1",
"react-grid-layout": "^0.16.0",
"react-grid-layout": "0.16.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment on the following line? Since JSON doesn't support comments, the best way might be to:
"//": "react-grid-layout 0.16.6 has know issue described in #4596"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully yarn and npm won't try to reorder the comment. Related: https://stackoverflow.com/questions/14221579/how-do-i-add-comments-to-package-json-for-npm-install

@graceguo-supercat
Copy link

LGTM

@graceguo-supercat graceguo-supercat merged commit 8951990 into apache:master Mar 12, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Mar 12, 2018
graceguo-supercat pushed a commit to airbnb/superset-fork that referenced this pull request Mar 12, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@yamyamyuo
Copy link
Contributor

@mistercrunch why not use this version "react-grid-layout": "^0.16.0", we prefer this version since charts won't move around while dragging one chart through other charts

@mistercrunch
Copy link
Member

@yamyamyuo we don't use react-grid-layout anymore 🎈 🥇

@yamyamyuo
Copy link
Contributor

@mistercrunch when does this version coming out? I just curious why the superset recent releases (eg. 0.26.2, 0.26.3) contains bugs that were found half year ago(like this one)? Does the new release version generate from master?

@yamyamyuo
Copy link
Contributor

@mistercrunch and one more question, what does the suffix means in release 0.27.0rc1, what's the difference with those releases without rc\d+? Thanks!

wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants