[druid] Adding cluster filter for refresh #4602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4602 +/- ##
=======================================
Coverage 71.18% 71.18%
=======================================
Files 189 189
Lines 14845 14845
Branches 1086 1086
=======================================
Hits 10567 10567
Misses 4275 4275
Partials 3 3
Continue to review full report at Codecov.
|
|
lgtm |
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Mar 13, 2018
…c-fix-filter [druid] Adding cluster filter for refresh (cherry picked from commit 037c041)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…c-fix-filter [druid] Adding cluster filter for refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with syncing of Druid datasources where the datasource name is not globally unique. Previously the filter didn't include the cluster name (unique) which is required as the cluster/datasource tuple ensures global uniqueness.
Note I also replace the OR filter with the more efficient IN.