forms: make csv import parse dates accepts a list of columns #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
force-pushed
the
csvimportparsedate
branch
3 times, most recently
from
0fafeee
to
e5155b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4639 +/- ##
=========================================
+ Coverage 71.37% 71.4% +0.02%
=========================================
Files 190 190
Lines 14918 14934 +16
Branches 1102 1102
=========================================
+ Hits 10648 10663 +15
- Misses 4267 4268 +1
Partials 3 3
Continue to review full report at Codecov.
|
|
@timifasubaa any chance you can take a look at this? I'll show this in a talk about superset tomorrow and I'd like that this or something equivalent will reach mainline. Thanks! |
Instead of a boolean which has way less chances to work. While at it add a proper label for the "con" field. Fixes apache#4637
xrmx
force-pushed
the
csvimportparsedate
branch
from
e5155b5
to
8ae10bd
Compare
|
LGTM |
|
Thanks @timifasubaa @graceguo-supercat ! |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…4639) Instead of a boolean which has way less chances to work. While at it add a proper label for the "con" field. Fixes apache#4637
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…4639) Instead of a boolean which has way less chances to work. While at it add a proper label for the "con" field. Fixes apache#4637
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a boolean which has way less chances to work. While
at it add a proper label for the "con" field.
Fixes #4637
cc @timifasubaa