CRUD hints around SQL expressions #4645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4645 +/- ##
==========================================
+ Coverage 71.23% 71.37% +0.14%
==========================================
Files 190 190
Lines 14884 14918 +34
Branches 1099 1102 +3
==========================================
+ Hits 10602 10648 +46
+ Misses 4279 4267 -12
Partials 3 3
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Mar 21, 2018
superset/connectors/sqla/views.py
Outdated
| @@ -57,8 +57,8 @@ class TableColumnInlineView(CompactCRUDMixin, SupersetModelView): # noqa | |||
| 'expression-defined columns in some cases. In most case ' | |||
| 'users should not need to alter this.'), | |||
| 'expression': utils.markdown( | |||
| 'a valid SQL expression as supported by the underlying backend. ' | |||
| 'Example: `substr(name, 1, 1)`', True), | |||
| 'a valid, non-aggregating SQL expression as supported by the ' | |||
There was a problem hiding this comment.
Nit: use stars around "non-aggregating", for consistency with the other chance below.
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* CRUD hints around SQL expressions * Addressing comment
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* CRUD hints around SQL expressions * Addressing comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.