Expose metrics to JS #4654
Merged
Expose metrics to JS #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4654 +/- ##
==========================================
- Coverage 71.25% 71.25% -0.01%
==========================================
Files 190 190
Lines 14916 14918 +2
Branches 1102 1102
==========================================
+ Hits 10629 10630 +1
- Misses 4284 4285 +1
Partials 3 3
Continue to review full report at Codecov.
|
| vm.runInNewContext(codeToEval, sandbox, opts); | ||
| return sandbox[resultKey]; | ||
| } catch (error) { | ||
| return () => error; |
There was a problem hiding this comment.
Why returning a function that returns an error?
There was a problem hiding this comment.
The function sandboxedEval returns a function (either to mutate the data or generate the tooltip). I'm being consistent here, and returning this ensures that the error is displayed in the tooltip (see second screenshot).
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vylc requested the ability of exposing the metrics to the JS advanced tooltip:
I also added a
try/exceptblock around the sandbox eval, so that the query still runs when the JS is broken, and the exception is shown: