Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lyftColor to the game 💯 #4682

Merged
merged 2 commits into from Mar 24, 2018
Merged

Add lyftColor to the game 💯 #4682

merged 2 commits into from Mar 24, 2018

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Mar 23, 2018

Because the branding matters 😛

@john-bodley
Copy link
Member

LGTM

@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #4682 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4682      +/-   ##
=========================================
+ Coverage    71.4%   71.4%   +<.01%     
=========================================
  Files         190     190              
  Lines       14934   14935       +1     
  Branches     1102    1102              
=========================================
+ Hits        10663   10664       +1     
  Misses       4268    4268              
  Partials        3       3
Impacted Files Coverage Δ
superset/assets/javascripts/modules/colors.js 77.08% <100%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00cab7e...e80a502. Read the comment docs.

@mistercrunch mistercrunch merged commit 9abc5c7 into apache:master Mar 24, 2018
hughhhh added a commit to lyft/incubator-superset that referenced this pull request Mar 27, 2018
* add lyftColor to the game 💯

* fix json
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* add lyftColor to the game 💯

* fix json
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* add lyftColor to the game 💯

* fix json
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants