Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up the Lyft color scheme #4684

Merged
merged 1 commit into from Mar 26, 2018
Merged

Conversation

mistercrunch
Copy link
Member

screen shot 2018-03-23 at 7 00 51 pm

Previous color scheme had too few colors, some with light tones and wasn't hooked up to the array.

Previous color scheme had too few colors, some with light tones
and wasn't hooked up to the array.
@codecov-io
Copy link

codecov-io commented Mar 24, 2018

Codecov Report

Merging #4684 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4684   +/-   ##
======================================
  Coverage    71.4%   71.4%           
======================================
  Files         190     190           
  Lines       14935   14935           
  Branches     1102    1102           
======================================
  Hits        10664   10664           
  Misses       4268    4268           
  Partials        3       3
Impacted Files Coverage Δ
superset/assets/javascripts/modules/colors.js 77.08% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abc5c7...ade5670. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented Mar 24, 2018

🚀

@mistercrunch mistercrunch merged commit 097a37a into apache:master Mar 26, 2018
@mistercrunch mistercrunch deleted the fix_lyft branch March 26, 2018 16:33
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
Previous color scheme had too few colors, some with light tones
and wasn't hooked up to the array.
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
Previous color scheme had too few colors, some with light tones
and wasn't hooked up to the array.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants