Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 3 letters month prefix in default date format #4693

Merged
merged 1 commit into from Mar 29, 2018

Conversation

mistercrunch
Copy link
Member

Using 3-letters month name is clear enough and allows for a smaller and even x axis margin on line charts.

@codecov-io
Copy link

Codecov Report

Merging #4693 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4693      +/-   ##
==========================================
+ Coverage   71.52%   71.53%   +<.01%     
==========================================
  Files         190      190              
  Lines       14927    14929       +2     
  Branches     1102     1102              
==========================================
+ Hits        10677    10679       +2     
  Misses       4247     4247              
  Partials        3        3
Impacted Files Coverage Δ
superset/assets/javascripts/modules/dates.js 86.04% <100%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d85bd...9bb00b2. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented Mar 29, 2018

🐑

@mistercrunch mistercrunch merged commit 2967868 into apache:master Mar 29, 2018
@mistercrunch mistercrunch deleted the short_month branch March 29, 2018 21:41
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Mar 30, 2018
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Mar 30, 2018
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Apr 4, 2018
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Apr 11, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants