Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename no_reload #4703

Merged
merged 1 commit into from Mar 28, 2018
Merged

Rename no_reload #4703

merged 1 commit into from Mar 28, 2018

Conversation

betodealmeida
Copy link
Member

The variable no_reload is true whenever we want to reload, and is false when we want no reload. I renamed it to use_reloader.

@codecov-io
Copy link

codecov-io commented Mar 28, 2018

Codecov Report

Merging #4703 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4703   +/-   ##
=======================================
  Coverage   71.56%   71.56%           
=======================================
  Files         191      191           
  Lines       14958    14958           
  Branches     1100     1100           
=======================================
  Hits        10705    10705           
  Misses       4250     4250           
  Partials        3        3
Impacted Files Coverage Δ
superset/cli.py 47.74% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485b0c2...dd3398d. Read the comment docs.

@mistercrunch mistercrunch merged commit 7e1b6b7 into apache:master Mar 28, 2018
@mistercrunch mistercrunch deleted the fix_no_reload_madness branch March 28, 2018 21:44
john-bodley pushed a commit to john-bodley/superset that referenced this pull request Apr 10, 2018
(cherry picked from commit 7e1b6b7)
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants