[explore] don't prompt to 'Run Query' on viewport change #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4729 +/- ##
==========================================
- Coverage 72.22% 72.22% -0.01%
==========================================
Files 204 204
Lines 15323 15324 +1
Branches 1180 1181 +1
==========================================
Hits 11067 11067
- Misses 4253 4254 +1
Partials 3 3
Continue to review full report at Codecov.
|
|
LGTM. I'm happy with the name, the only other thing I can think of is |
betodealmeida
approved these changes
Apr 2, 2018
|
Nice! Glad you found a way out. Closing my old PR. |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take on #4610
I couldn't come up with a better name than
dontRefreshOnChangeas I needed a "truthy" attribute to avoid having to touch all other controls.@GabeLoins