[line] fix verbose names in time shift #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4765 +/- ##
==========================================
- Coverage 72.64% 72.63% -0.02%
==========================================
Files 205 205
Lines 15402 15403 +1
Branches 1183 1183
==========================================
- Hits 11189 11188 -1
- Misses 4210 4212 +2
Partials 3 3
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Apr 6, 2018
| bar: 'Bar', | ||
| }; | ||
| describe('formatLabel', () => { | ||
| it('is formats simple labels', () => { |
There was a problem hiding this comment.
Nit, drop the "is"?
it('formats simple labels', () => {
| const verboseLabels = input.filter(s => s !== '---').map(verboseLkp); | ||
| label = verboseLabels.join(', '); | ||
| if (input.length > verboseLabels.length) { | ||
| label += '---'; |
There was a problem hiding this comment.
Did you test leaving a space between the label and the dashes? Seems a bit cluttered to me without the space there.
mistercrunch
force-pushed
the
fix_time_shift_label
branch
from
04dbe3c
to
f288919
Compare
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 11, 2018
* [line] fix verbose names in time shift * Addressing comments
|
@mistercrunch it looks like this broke the time shift color assignment (that you fixed here #4202), but it seemed like that broke the verbose names in time shift. Any thoughts on how to solve for both cases? |
mistercrunch
added a commit
to mistercrunch/superset
that referenced
this pull request
May 23, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* [line] fix verbose names in time shift * Addressing comments
mistercrunch
added a commit
that referenced
this pull request
May 24, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
closes apache#4765 (cherry picked from commit 05061a7)
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* [line] fix verbose names in time shift * Addressing comments
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* [line] fix verbose names in time shift * Addressing comments
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com//issues/4750