Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the bottom margin a bit taller #4807

Merged
merged 1 commit into from Apr 11, 2018
Merged

Make the bottom margin a bit taller #4807

merged 1 commit into from Apr 11, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Apr 11, 2018 •
edited

Before

screen shot 2018-04-11 at 10 10 33 am

screen shot 2018-04-11 at 10 06 32 am

after

screen shot 2018-04-11 at 10 11 39 am

screen shot 2018-04-11 at 10 11 19 am

@codecov-io
Copy link

codecov-io commented Apr 11, 2018 •
edited

Codecov Report

Merging #4807 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4807   +/-   ##
=======================================
  Coverage   72.29%   72.29%           
=======================================
  Files         208      208           
  Lines       15522    15522           
  Branches     1202     1202           
=======================================
  Hits        11222    11222           
  Misses       4297     4297           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf9ec0...8995c37. Read the comment docs.

betodealmeida
betodealmeida approved these changes Apr 11, 2018
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks much better.

@mistercrunch mistercrunch merged commit 683fb6c into apache:master Apr 11, 2018
@mistercrunch mistercrunch deleted the margin_tweak branch April 11, 2018 22:16
@mistercrunch
Copy link
Member Author

Yeah I had validated the changes mostly in the explore view which has it's own padding, so I missed how close to the edge is was.

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Make the bottom margin a bit taller (apache#4807)
bd571b7
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
@mistercrunch @timifasubaa
Make the bottom margin a bit taller (apache#4807)
4db1c79
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
Make the bottom margin a bit taller (apache#4807)
86f816e
@mistercrunch mistercrunch mentioned this pull request Dec 12, 2018
Closed
3 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mistercrunch @codecov-io @betodealmeida