Fix for week_start_sunday and week_ending_saturday #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4911 +/- ##
=======================================
Coverage 77.14% 77.14%
=======================================
Files 44 44
Lines 8539 8539
=======================================
Hits 6587 6587
Misses 1952 1952
Continue to review full report at Codecov.
|
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
May 2, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
May 16, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
May 30, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
May 30, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 4, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 7, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 7, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 7, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 7, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 27, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests (cherry picked from commit 13da5a8)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Handle locked weeks * Fix spelling * Fix druid * Clean unit tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The granularity options
week_ending_saturday("truncate forward til next Saturday") andweek_start_sunday("truncate back til last Sunday") are not working correctly. Currently the granularity dropdown has the same key (P1W, one week) forweek,week_ending_saturdayandweek_start_sunday, and only the first one can be selected.I fixed this bug by making the key unique. The ISO 8601 spec supports
time intervals, so I used1969-12-28T00:00:00Z/P1Wto representweek_start_sunday(since 1969-12-28 was a Sunday), andP1W/1970-01-03T00:00:00Zto representweek_ending_saturday(since 1970-01-03 was a Saturday). This required modifying thegetPlaySliderParamsfunction, since it parses the ISO duration in order to get its props.I also added these two granularities to the SQLite backend, in order to test it.