Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos from linting #4918

Merged
merged 1 commit into from
May 1, 2018
Merged

Conversation

mistercrunch
Copy link
Member

Caused by #3847

Fixes #4915

Greped for more of this pattern but didn't find other errors. @john-bodley please check if you can think of what went wrong and whether other similar patterns may be affected.

@codecov-io
Copy link

Codecov Report

Merging #4918 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4918   +/-   ##
=======================================
  Coverage   77.14%   77.14%           
=======================================
  Files          44       44           
  Lines        8539     8539           
=======================================
  Hits         6587     6587           
  Misses       1952     1952
Impacted Files Coverage Δ
superset/db_engine_specs.py 52.69% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c94e1f...36ebd6e. Read the comment docs.

@mistercrunch mistercrunch merged commit 5f6a1ce into apache:master May 1, 2018
@mistercrunch mistercrunch deleted the fix_typos branch May 1, 2018 20:34
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exploring BQ table throws query error as date is incorrectly formatted
4 participants