Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superset/import_dashboards.html: Update title, clean up html #4972

Conversation

sodevious
Copy link
Contributor

Soley a template/front-end change.

  • Changes "Import the dashboards." to "Import dashboards"
  • Cleans up the HTML to add quotes, self close tags, etc.
  • Adds a class to the <submit> button to utilize bootstrap style
  • Remove the <title> tag in body as it's not vaild HTML and redundant with {% block title %}

* Changes "Import the dashboards." to "Import dashboards"
* Cleans up the HTML to add quotes, self close tags, etc.
* Adds a class to the `<submit>` button to utilize bootstrap style
* Remove the `<title>` tag in body as it's not vaild HTML and redundant with `{% block %}`
@codecov-io
Copy link

Codecov Report

Merging #4972 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4972   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files          44       44           
  Lines        8595     8595           
=======================================
  Hits         6621     6621           
  Misses       1974     1974

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 918399d...f3934f1. Read the comment docs.

@mistercrunch mistercrunch merged commit 94249ed into apache:master May 10, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
…4972)

* Changes "Import the dashboards." to "Import dashboards"
* Cleans up the HTML to add quotes, self close tags, etc.
* Adds a class to the `<submit>` button to utilize bootstrap style
* Remove the `<title>` tag in body as it's not vaild HTML and redundant with `{% block %}`
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
…4972)

* Changes "Import the dashboards." to "Import dashboards"
* Cleans up the HTML to add quotes, self close tags, etc.
* Adds a class to the `<submit>` button to utilize bootstrap style
* Remove the `<title>` tag in body as it's not vaild HTML and redundant with `{% block %}`
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
…4972)

* Changes "Import the dashboards." to "Import dashboards"
* Cleans up the HTML to add quotes, self close tags, etc.
* Adds a class to the `<submit>` button to utilize bootstrap style
* Remove the `<title>` tag in body as it's not vaild HTML and redundant with `{% block %}`
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants