Use a dummy version number on master #5000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we assign release version number in release branches and master was still pointing to some old version number from when the process was different. We need a dummy version number that both setuptools and npm are ok with.
Codecov Report
@@ Coverage Diff @@
## master #5000 +/- ##
======================================
Coverage 77.1% 77.1%
======================================
Files 44 44
Lines 8636 8636
======================================
Hits 6659 6659
Misses 1977 1977Continue to review full report at Codecov.
|
xrmx
reviewed
May 15, 2018
|
@xrmx it means an extra PR at every release and it's easy to forget. |
|
Merging since this is better than stale. |
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
Currently we assign release version number in release branches and master was still pointing to some old version number from when the process was different. We need a dummy version number that both setuptools and npm are ok with.
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
Currently we assign release version number in release branches and master was still pointing to some old version number from when the process was different. We need a dummy version number that both setuptools and npm are ok with.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
Currently we assign release version number in release branches and master was still pointing to some old version number from when the process was different. We need a dummy version number that both setuptools and npm are ok with.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we assign release version number in release branches and
master was still pointing to some old version number from when the
process was different. We need a dummy version number that both setuptools
and npm are ok with.
fixes #4999