[Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
force-pushed
the
gabe_forcing_ace_editor_to_refresh
branch
from
fe6a7c4
to
1db80df
Compare
gabe-lyons
force-pushed
the
gabe_forcing_ace_editor_to_refresh
branch
from
1db80df
to
719c625
Compare
Codecov Report
@@ Coverage Diff @@
## master #5038 +/- ##
=======================================
Coverage 77.34% 77.34%
=======================================
Files 44 44
Lines 8671 8671
=======================================
Hits 6707 6707
Misses 1964 1964Continue to review full report at Codecov.
|
|
LGTM |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 21, 2018
(cherry picked from commit 0e1fb62)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AceEditor has an optimization where it won't refresh itself if its value is set while the editor is hidden. (ajaxorg/ace#2497) Since the editor is hidden when its tab isn't selected, the editor has a stale value when it is shown after changes were made in the Simple tab.
In this PR I force refresh the editor using its exposed
resizemethod every time it is foregroundedtest plan:
reviewers:
@michellethomas @john-bodley @graceguo-supercat @mistercrunch