Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[line] fix time shift color assignments #5065

Merged
merged 1 commit into from May 24, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented May 23, 2018

@michellethomas I think what happened is last minute "addressing comments" changes broke the PR.

related to #4765

@codecov-io
Copy link

Codecov Report

Merging #5065 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5065   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files          44       44           
  Lines        8712     8712           
=======================================
  Hits         6755     6755           
  Misses       1957     1957

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d322e48...32b2c54. Read the comment docs.

Copy link
Contributor

@michellethomas michellethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@mistercrunch mistercrunch merged commit 05061a7 into apache:master May 24, 2018
@mistercrunch mistercrunch deleted the fix_color branch May 24, 2018 04:30
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
john-bodley added a commit that referenced this pull request May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this pull request May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants