Refactor NULL handling into method, disable for DECK.gl vizes #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5106 +/- ##
==========================================
+ Coverage 77.5% 77.51% +0.01%
==========================================
Files 44 44
Lines 8720 8724 +4
==========================================
+ Hits 6758 6762 +4
Misses 1962 1962
Continue to review full report at Codecov.
|
john-bodley
reviewed
May 31, 2018
| @@ -145,6 +145,10 @@ def run_extra_queries(self): | |||
| """ | |||
| pass | |||
|
|
|||
| def handle_nulls(self, df): | |||
| fillna = self.get_fillna_for_columns(df.columns) | |||
| df = df.fillna(fillna) | |||
There was a problem hiding this comment.
Maybe df.fillna(fillna, inplace=True).
There was a problem hiding this comment.
It's effectively the same, are there perf implications?
There was a problem hiding this comment.
Also just moving original code to under a function
hughhhh
reviewed
May 31, 2018
| @@ -2041,6 +2044,9 @@ class BaseDeckGLViz(BaseViz): | |||
| credits = '<a href="https://uber.github.io/deck.gl/">deck.gl</a>' | |||
| spatial_control_keys = [] | |||
|
|
|||
| def handle_nulls(self, df): | |||
| pass | |||
There was a problem hiding this comment.
let's raise a raise NotImplementedError()
There was a problem hiding this comment.
oh here I actually want to do nothing
|
🚢 |
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
handle_nullsto its own method will allow visualizations to override this part.This specifically turns off null handling for DECK.gl visualizations as there are issues with spatial dimensions getting replaced by
" NULL"which triggers errors in places whereNULLorNoneare handled properly.Following this simple refactor, we can move forward with more appropriate and per-visualization defined null handling.
@betodealmeida @john-bodley