Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing time table viz for adhoc metrics #5117

Merged

Conversation

michellethomas
Copy link
Contributor

The time table viz is broken for adhoc metrics. In the time table viz MetricOption is passed metric information that was gathered from slice.datasource.metrics, but AdhocMetrics aren't in that list so it errors. We can pass through the metric if it's already an object.

MetricOption in this case is just being used to display the metric name or verbose name with a link from a given url. So it's not a problem that metrics from the database are structured differently from AdhocMetrics, the label/name/verbose name is the only necessary prop.

@GabeLoins @mistercrunch @graceguo-supercat

@mistercrunch
Copy link
Member

LGTM

@codecov-io
Copy link

codecov-io commented May 31, 2018

Codecov Report

Merging #5117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5117   +/-   ##
=======================================
  Coverage   77.52%   77.52%           
=======================================
  Files          44       44           
  Lines        8728     8728           
=======================================
  Hits         6766     6766           
  Misses       1962     1962

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3778c3...51b4d39. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit ff4b103 into apache:master May 31, 2018
michellethomas added a commit to michellethomas/panoramix that referenced this pull request Jun 6, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants