Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin FAB to 1.10.0 #5133

Merged
merged 1 commit into from Jun 4, 2018
Merged

Pin FAB to 1.10.0 #5133

merged 1 commit into from Jun 4, 2018

Conversation

mistercrunch
Copy link
Member

Related to
#5088 (comment)

@mistercrunch mistercrunch mentioned this pull request Jun 4, 2018
Closed
@xrmx
Copy link
Contributor

xrmx commented Jun 4, 2018

Isn't it the very same of mine? #5091

@mistercrunch
Copy link
Member Author

Oh right. Merging yours.

@mistercrunch mistercrunch reopened this Jun 4, 2018
@villebro
Copy link
Member

villebro commented Jun 4, 2018

Haha, I had a similar one in, too, I need to pay more attention to other PRs.

@mistercrunch
Copy link
Member Author

Merging this one to since other PR targeted 0.25 branch.

@mistercrunch
Copy link
Member Author

Pushed 0.25.6 out with this fix btw.

@mistercrunch mistercrunch merged commit ffd65ce into apache:master Jun 4, 2018
@mistercrunch mistercrunch deleted the pin_fab2 branch June 4, 2018 16:03
@codecov-io
Copy link

codecov-io commented Jun 4, 2018 •
edited

Codecov Report

Merging #5133 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5133   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files          44       44           
  Lines        8734     8734           
=======================================
  Hits         6770     6770           
  Misses       1964     1964

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc21e0d...7fca0fd. Read the comment docs.

timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
@mistercrunch @timifasubaa
Pin FAB to 1.10.0 (apache#5133)
1e307b1 
Related to
apache#5088 (comment)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
Pin FAB to 1.10.0 (apache#5133)
769da97 
Related to
apache#5088 (comment)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mistercrunch @xrmx @villebro @codecov-io