Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] add support for numeric nodes in Sankey #5154

Merged
merged 2 commits into from
Jun 22, 2018

Conversation

mistercrunch
Copy link
Member

closes #5142

@codecov-io
Copy link

Codecov Report

Merging #5154 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5154      +/-   ##
==========================================
- Coverage   77.47%   77.47%   -0.01%     
==========================================
  Files          44       44              
  Lines        8741     8732       -9     
==========================================
- Hits         6772     6765       -7     
+ Misses       1969     1967       -2
Impacted Files Coverage Δ
superset/viz.py 81.33% <100%> (+0.03%) ⬆️
superset/connectors/druid/models.py 80.49% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e1256...8cc2e26. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented Jun 19, 2018

🚢

@mistercrunch mistercrunch merged commit b344056 into apache:master Jun 22, 2018
@mistercrunch mistercrunch deleted the fix_numeric_sankey branch June 22, 2018 01:09
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
* [bugfix] add support for numeric nodes in Sankey

closes apache#5142

* lint
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* [bugfix] add support for numeric nodes in Sankey

closes apache#5142

* lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
3 participants