[Explore][Adhoc Filters] empty lists are invalid comparators

[gabe-lyons]

Thanks to @michellethomas for reporting. Previously it was valid to add a simple filter formatted as column in () or NOT column in (). These are both relatively useless clauses as the first will always evaluate to true and the second will always evaluate to false. I added a check to prevent this filters from being added.

Now the button will be disabled if the comparator is an empty list:

test plan:

• tried to add a column in () simple filter and verified I could not
• ran the specs

@michellethomas @john-bodley @graceguo-supercat @mistercrunch

[codecov-io]

Codecov Report

Merging #5160 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5160   +/-   ##
=======================================
  Coverage   77.47%   77.47%           
=======================================
  Files          44       44           
  Lines        8741     8741           
=======================================
  Hits         6772     6772           
  Misses       1969     1969

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e1256...6b28c08. Read the comment docs.

[michellethomas]

Woo! lgtm thanks so much for doing this!