Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] form_data - fix empty metrics #5190

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

timifasubaa
Copy link
Contributor

@timifasubaa timifasubaa commented Jun 13, 2018

This change introduced a regression (#5026)

Sometimes metrics can be set to None and the function assumes wrongly that if the metrics variable is specified, it must be a list. This PR fixes the regression.

@john-bodley @michellethomas

@codecov-io
Copy link

Codecov Report

Merging #5190 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5190   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files          44       44           
  Lines        8730     8730           
=======================================
  Hits         6763     6763           
  Misses       1967     1967
Impacted Files Coverage Δ
superset/viz.py 81.29% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6846d9...95bb175. Read the comment docs.

@timifasubaa timifasubaa merged commit 6e37d3f into apache:master Jun 14, 2018
@rzlmma
Copy link

rzlmma commented Jun 15, 2018

I'm more inclined to the last version, because the following code determines that it's value is an iterator.

wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
[bugfix] form_data - fix empty metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants