Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql lab] quote schema and table name #5195

Merged
merged 1 commit into from Jun 18, 2018

Conversation

mistercrunch
Copy link
Member

fixes #4595, basically handling table names with spaces or special characters in them

@codecov-io
Copy link

codecov-io commented Jun 14, 2018

Codecov Report

Merging #5195 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5195      +/-   ##
==========================================
+ Coverage   63.45%   63.46%   +<.01%     
==========================================
  Files         261      261              
  Lines       19822    19825       +3     
  Branches     1989     1989              
==========================================
+ Hits        12579    12582       +3     
  Misses       7234     7234              
  Partials        9        9
Impacted Files Coverage Δ
superset/models/core.py 86.56% <100%> (+0.02%) ⬆️
superset/db_engine_specs.py 53.87% <75%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a109543...61a61d3. Read the comment docs.

Copy link
Contributor

@gbates101 gbates101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Better solution than what I proposed.

@mistercrunch
Copy link
Member Author

Ended spending time trying to use sqlalchemy.table (not schema aware) and sqlalchemy.Table which requires Metadata context, which didn't work at well. Finally figured out how to get the quoting function of the dialect.

@mistercrunch
Copy link
Member Author

@mistercrunch mistercrunch merged commit c89933d into apache:master Jun 18, 2018
@mistercrunch mistercrunch deleted the quote_table_name branch June 18, 2018 15:42
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.26.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqllab: preview should quote table name
4 participants