Moving homogenize_types to after no data exception #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
approved these changes
Jun 15, 2018
michellethomas
force-pushed
the
fix_groupby_no_data
branch
from
9cfd2eb
to
bbccf55
Compare
Codecov Report
@@ Coverage Diff @@
## master #5214 +/- ##
=======================================
Coverage 63.28% 63.28%
=======================================
Files 259 259
Lines 19689 19689
Branches 1968 1968
=======================================
Hits 12461 12461
Misses 7219 7219
Partials 9 9
Continue to review full report at Codecov.
|
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jun 27, 2018
(cherry picked from commit eb67651)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a chart has a group by and no data it will error on homogenize_types with
'NoneType' object is not subscriptable. This will show the No data exception before it hits the error.@mistercrunch @john-bodley