Revert "[webpack] setup lazy loading for all visualizations" #5219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
approved these changes
Jun 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #5219 +/- ##
===========================================
- Coverage 77.48% 63.39% -14.09%
===========================================
Files 44 261 +217
Lines 8749 19959 +11210
Branches 0 2053 +2053
===========================================
+ Hits 6779 12654 +5875
- Misses 1970 7296 +5326
- Partials 0 9 +9
Continue to review full report at Codecov.
|
Artic2019
added a commit
to Artic2019/incubator-superset
that referenced
this pull request
Jun 17, 2018
…pache#5219)" This reverts commit 7b49b6c.
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
…5219) * Revert "[explore] fix autocomplete on verbose names (apache#5204)" This reverts commit d5ebc43. * Revert "[webpack] setup lazy loading for all visualizations (apache#4727)" This reverts commit de0aaf4.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…5219) * Revert "[explore] fix autocomplete on verbose names (apache#5204)" This reverts commit d5ebc43. * Revert "[webpack] setup lazy loading for all visualizations (apache#4727)" This reverts commit de0aaf4.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4727
Going to revert this for now since it seems it broke the coverage part of the JS build (tests seem to pass?!) and we haven't been able to fix it despite trying several config tweaks.
@john-bodley