[Druid] Improving performance by disabling editing Associated Chart #5238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5238 +/- ##
=======================================
Coverage 63.46% 63.46%
=======================================
Files 261 261
Lines 19845 19845
Branches 1998 1998
=======================================
Hits 12594 12594
Misses 7242 7242
Partials 9 9
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Jun 18, 2018
|
LGTM |
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Jun 18, 2018
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #5136 this PR helps to improve the performance of datasource CRUD view by removing the slices (Associated Charts) column from the edit view (it's still present for show).
to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa