[druid] Adding verbose_name to editable columns #5249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5249 +/- ##
=======================================
Coverage 60.76% 60.76%
=======================================
Files 258 258
Lines 19701 19701
Branches 1970 1970
=======================================
Hits 11972 11972
Misses 7720 7720
Partials 9 9
Continue to review full report at Codecov.
|
|
lgtm |
|
Actually, verbose name is set it get_metrics, so wouldn't the field just be overwritten if someone tries to edit it? |
|
@michellethomas this is for a Druid column rather than a metric. |
|
oh well then ignore my comment lgtm |
|
LGTM |
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Jun 25, 2018
(cherry picked from commit 7de5023)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Druid column verbose name as an editable column, inline with SQLA columns.
to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa