Revert "[perf] add webpack 4 + SplitChunks + lazy load visualizations" #5253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 😢 Specifically the global notify package is breaking this (we should not have global packages ... dashboard v2 introduces a redux-based notification system), and I'm not sure what the cause of the duplicate resource requests (for things like theme/font) is but this is an example
|
Codecov Report
@@ Coverage Diff @@
## master #5253 +/- ##
=========================================
+ Coverage 60.76% 63.66% +2.9%
=========================================
Files 258 261 +3
Lines 19708 20126 +418
Branches 1972 2079 +107
=========================================
+ Hits 11976 12814 +838
+ Misses 7723 7301 -422
- Partials 9 11 +2
Continue to review full report at Codecov.
|
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Jun 20, 2018
apache#5253) * Revert "[sqllab] Fix sql lab resolution link (apache#5216)" This reverts commit 93cdf60. * Revert "Pin botocore version (apache#5184)" This reverts commit 70679d4. * Revert "Describe the use of custom OAuth2 authorization servers (apache#5220)" This reverts commit a84f430. * Revert "[bubble-chart] Fixing issue w/ metric names (apache#5237)" This reverts commit 5c106b9. * Revert "[adhoc-filters] Adding adhoc-filters to all viz types (apache#5206)" This reverts commit d483ed1. * Revert "[perf] add webpack 4 + SplitChunks + lazy load visualizations (apache#5240)" This reverts commit 1fc4ee0. (cherry picked from commit 62427c8)
|
I agree about removing the global notify package. |
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
apache#5253) * Revert "[sqllab] Fix sql lab resolution link (apache#5216)" This reverts commit 93cdf60. * Revert "Pin botocore version (apache#5184)" This reverts commit 70679d4. * Revert "Describe the use of custom OAuth2 authorization servers (apache#5220)" This reverts commit a84f430. * Revert "[bubble-chart] Fixing issue w/ metric names (apache#5237)" This reverts commit 5c106b9. * Revert "[adhoc-filters] Adding adhoc-filters to all viz types (apache#5206)" This reverts commit d483ed1. * Revert "[perf] add webpack 4 + SplitChunks + lazy load visualizations (apache#5240)" This reverts commit 1fc4ee0.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
apache#5253) * Revert "[sqllab] Fix sql lab resolution link (apache#5216)" This reverts commit 93cdf60. * Revert "Pin botocore version (apache#5184)" This reverts commit 70679d4. * Revert "Describe the use of custom OAuth2 authorization servers (apache#5220)" This reverts commit a84f430. * Revert "[bubble-chart] Fixing issue w/ metric names (apache#5237)" This reverts commit 5c106b9. * Revert "[adhoc-filters] Adding adhoc-filters to all viz types (apache#5206)" This reverts commit d483ed1. * Revert "[perf] add webpack 4 + SplitChunks + lazy load visualizations (apache#5240)" This reverts commit 1fc4ee0.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5240
Sorry we're reverting this again as there still a couple of issues we're noticed including i) a notify error which causes some charts to not load, and ii) duplicate requests being sent.
to: @mistercrunch @williaster