[get_df] Fix datetime conversion #5274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
changed the title
john-bodley
force-pushed
the
john-bodley-fix-dttm-issue
branch
from
0c0287c
to
40b501e
Compare
john-bodley
changed the title
john-bodley
force-pushed
the
john-bodley-fix-dttm-issue
branch
3 times, most recently
from
dcdf3f5
to
6342c31
Compare
Codecov Report
@@ Coverage Diff @@
## master #5274 +/- ##
=========================================
- Coverage 61.3% 61.3% -0.01%
=========================================
Files 368 368
Lines 23453 23452 -1
Branches 2713 2713
=========================================
- Hits 14378 14377 -1
Misses 9063 9063
Partials 12 12
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley-fix-dttm-issue
branch
from
6342c31
to
37b8a9b
Compare
john-bodley
force-pushed
the
john-bodley-fix-dttm-issue
branch
from
37b8a9b
to
9527872
Compare
| if df is None or df.empty: | ||
| return pd.DataFrame() | ||
| else: | ||
| if not df.empty: |
There was a problem hiding this comment.
You removed the check for df is None does that mean df won't be None? Will we still be passing an empty data frame if there's no data?
There was a problem hiding this comment.
The check was only there because we were mocking the pandas.DataFrame. The data is obtained from pandas.read_sql_query which returns a pandas.DataFrame object.
|
lgtm |
1 similar comment
|
lgtm |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jun 27, 2018
(cherry picked from commit 117507c)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 27, 2018
(cherry picked from commit 117507c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 31, 2018
(cherry picked from commit 117507c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
(cherry picked from commit 117507c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
(cherry picked from commit 117507c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
(cherry picked from commit 117507c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
(cherry picked from commit 117507c)
mistercrunch
pushed a commit
that referenced
this pull request
Aug 12, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🍒 0.27.0
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where epoch time columns which have already been converted to a timestamp (of type string) in the query are trying to be coerced in Pandas as a timestamp under the assumption that these values are still in the epoch format. Given these are already timestamps one merely needs to cast them to a
pandas.Timestampobject.to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa