Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin boto3 to 1.4.7 #5290

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Pin boto3 to 1.4.7 #5290

merged 1 commit into from
Jun 27, 2018

Conversation

jeffreythewang
Copy link
Contributor

@jeffreythewang jeffreythewang commented Jun 26, 2018

Since botocore is pinned to botocore>=1.7.0, <1.8.0 as per #5184 , boto3 should also be pinned, as boto3==1.4.6 depends on botocore>=1.6.0, <1.7.0 and boto3==1.4.8 depends on botocore>=1.8.0, <1.9.0.

cc: @mistercrunch @ledor473 @john-bodley

@codecov-io
Copy link

Codecov Report

Merging #5290 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5290   +/-   ##
======================================
  Coverage    61.3%   61.3%           
======================================
  Files         368     368           
  Lines       23453   23453           
  Branches     2713    2713           
======================================
  Hits        14378   14378           
  Misses       9063    9063           
  Partials       12      12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0eee12...f6c30de. Read the comment docs.

@williaster
Copy link
Contributor

I made this change and it fixed my local build. not sure if this is better or #5286 (didn't test that one)

@jeffreythewang
Copy link
Contributor Author

jeffreythewang commented Jun 26, 2018

Yeah tbh we don't use either of these libraries so I don't know if we should have the final say on this one. But if we're going to pin botocore to anything, we'll have to pin boto3 as well. It seems like #5286 requires boto3==1.4.8.

@mistercrunch
Copy link
Member

Ok let me merge this, we can iterate if needed.

@mistercrunch mistercrunch merged commit fb988fe into apache:master Jun 27, 2018
mistercrunch pushed a commit that referenced this pull request Jun 28, 2018
(cherry picked from commit fb988fe)
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🍒 0.26.0 🍒 0.26.1 🍒 0.26.2 🍒 0.26.3 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.26.0 🍒 0.26.1 🍒 0.26.2 🍒 0.26.3 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants