[dashboard fix] force refresh charts under tabs #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@graceguo-supercat what do you think about a different fix where we simply don't fetch data for charts that haven't been rendered? that would reduce the query time as well. |
graceguo-supercat
force-pushed
the
gg-DashFix-forceRefreshWithTabs
branch
from
3168a26
to
3a93201
Compare
williaster
reviewed
Jun 26, 2018
| @@ -202,5 +202,10 @@ export function runQuery(formData, force = false, timeout = 60, key) { | |||
| } | |||
|
|
|||
| export function refreshChart(chart, force, timeout) { | |||
| return dispatch => dispatch(runQuery(chart.latestQueryFormData, force, timeout, chart.id)); | |||
| return dispatch => { | |||
| if (Object.keys(chart.latestQueryFormData).length === 0) { | |||
There was a problem hiding this comment.
should there also be a check for whether chart.latestQueryFormData is defined or is that guaranteed to be there?
There was a problem hiding this comment.
it is initialized from getInitialState in line 79:
https://github.com/apache/incubator-superset/blob/c06531950869d84a50e7914b945ba6ceb2a5c179/superset/assets/src/dashboard/reducers/getInitialState.js#L79
There was a problem hiding this comment.
can we add the check JIC since there is no downside to adding it?
graceguo-supercat
force-pushed
the
gg-DashFix-forceRefreshWithTabs
branch
from
3a93201
to
34b6f79
Compare
williaster
approved these changes
Jun 26, 2018
graceguo-supercat
force-pushed
the
gg-DashFix-forceRefreshWithTabs
branch
from
34b6f79
to
54cd99b
Compare
Codecov Report
@@ Coverage Diff @@
## master #5291 +/- ##
==========================================
- Coverage 61.3% 61.29% -0.01%
==========================================
Files 368 368
Lines 23455 23457 +2
Branches 2715 2716 +1
==========================================
Hits 14379 14379
- Misses 9064 9066 +2
Partials 12 12
Continue to review full report at Codecov.
|
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jun 27, 2018
(cherry picked from commit 4ee984c)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
(cherry picked from commit 4ee984c)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
(cherry picked from commit 4ee984c)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
(cherry picked from commit 4ee984c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
(cherry picked from commit 4ee984c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
(cherry picked from commit 4ee984c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 27, 2018
(cherry picked from commit 4ee984c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 31, 2018
(cherry picked from commit 4ee984c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
(cherry picked from commit 4ee984c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
(cherry picked from commit 4ee984c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
(cherry picked from commit 4ee984c)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
(cherry picked from commit 4ee984c)
mistercrunch
pushed a commit
that referenced
this pull request
Aug 12, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🍒 0.27.0
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when user created top level tabs and place charts under it, initial page load won't fetch those charts data. But if user force refresh dashboard, currently we force refresh all charts even not visible ones. It cause js exception because some attributes are not well initialized.
updated solution: when user force refresh whole dashboard, don't fetch data for charts that haven't been rendered.