[dashboard fix]: Fix default_filters validation #5297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5297 +/- ##
=========================================
+ Coverage 61.29% 61.3% +<.01%
=========================================
Files 368 368
Lines 23457 23457
Branches 2716 2716
=========================================
+ Hits 14379 14381 +2
+ Misses 9066 9064 -2
Partials 12 12
Continue to review full report at Codecov.
|
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jun 27, 2018
(cherry picked from commit 17b4298)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
(cherry picked from commit 17b4298)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 11, 2018
(cherry picked from commit 17b4298)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
(cherry picked from commit 17b4298)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
(cherry picked from commit 17b4298)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 26, 2018
(cherry picked from commit 17b4298)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 27, 2018
(cherry picked from commit 17b4298)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 31, 2018
(cherry picked from commit 17b4298)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
(cherry picked from commit 17b4298)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
(cherry picked from commit 17b4298)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
(cherry picked from commit 17b4298)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
(cherry picked from commit 17b4298)
mistercrunch
pushed a commit
that referenced
this pull request
Aug 12, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🍒 0.27.0
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if user update dashboard default_filters metadata with invalid slice_id (a slice not included in the dashboard), we should not add this slice id into dashboard metadata. This PR is to fix
error dictionary changed size during iterationin python3@williaster @john-bodley @mistercrunch