Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize column names for Redshift #5337

Merged
merged 1 commit into from
Jul 4, 2018
Merged

normalize column names for Redshift #5337

merged 1 commit into from
Jul 4, 2018

Conversation

minh5
Copy link
Contributor

@minh5 minh5 commented Jul 3, 2018

This fixes an error with column names when using RedShift, issue is detailed here #5308.

@codecov-io
Copy link

codecov-io commented Jul 3, 2018

Codecov Report

Merging #5337 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5337      +/-   ##
==========================================
- Coverage   61.33%   61.33%   -0.01%     
==========================================
  Files         369      369              
  Lines       23484    23486       +2     
  Branches     2713     2713              
==========================================
+ Hits        14405    14406       +1     
- Misses       9067     9068       +1     
  Partials       12       12
Impacted Files Coverage Δ
superset/db_engine_specs.py 54.27% <50%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d815c...19da2a4. Read the comment docs.

@mistercrunch mistercrunch merged commit 059b64d into apache:master Jul 4, 2018
@minh5
Copy link
Contributor Author

minh5 commented Jul 5, 2018

@mistercrunch did this make it through to the new releases? I do not believe I see them in 26.2 and 26.3?

@mistercrunch
Copy link
Member

No it didn't. Adding a tag to pick it up on the next micro release

@mistercrunch
Copy link
Member

Since you're a contributor I would recommend making your own build and pick whatever cherries you want on your build without depending on official releases.

@minh5
Copy link
Contributor Author

minh5 commented Jul 6, 2018

Ah gotcha @mistercrunch, I'm pretty new to this. I have been doing this workaround but just wanted to know more about the process (and also to simply my deployment a bit). Many thanks

timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wyndhblb added a commit to asappinc/incubator-superset that referenced this pull request Oct 22, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels v0.26 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants