added a 'no_trend_line' option

[xiaoyugit]

[codecov-io]

Codecov Report

Merging #5356 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5356      +/-   ##
==========================================
- Coverage   61.33%   61.33%   -0.01%     
==========================================
  Files         369      369              
  Lines       23488    23489       +1     
  Branches     2713     2714       +1     
==========================================
  Hits        14407    14407              
- Misses       9069     9070       +1     
  Partials       12       12

Impacted Files	Coverage Δ
superset/assets/src/explore/visTypes.js	55.55% <ø> (ø)	⬆️
superset/assets/src/explore/controls.jsx	47.32% <ø> (ø)	⬆️
superset/assets/src/visualizations/big_number.js	8.24% <0%> (-0.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252cba2...6feec49. Read the comment docs.

[williaster]

@xiaohanyu @mistercrunch it would have been great to clean up the code and consolidate vis types, deprecating the "big number" without trend line, in this PR. Now we have two vis types that essentially do the same thing (one with a superset of functionality over the other).

[mistercrunch]

@williaster this one will take the latest available dot in the time series where "Big Number" would disregard the time granularity.

Personally I'm ok with a revert on this if you prefer. I know you had touched big_number.js in the past and there's an open PR on this. Happy to defer to that.

I'll make sure to keep PRs open longer before merging them to allow for more input.

[xiaohanyu]

@williaster I'm sorry but you @ the wrong person, LOL~

[xiaoyugit]

@xiaohanyu LOL~ guess I am the wrong person.
@williaster @mistercrunch given different ways of handling time granularity, I don't think these two plots are redundant on functionality. Personally I would love to keep a number plot with Month-over-Month comparison but without the trend line (for tidiness).

[williaster]

@xiaohanyu sorry about that! 🙉

@mistercrunch @xiaoyugit thanks for the thoughts. I think these two are still really redundant and the granularity difference could be handled with more config options. Will keep the two for now, though, since that's more work / would need a migration.