Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set control 'percent_metrics's default to [] #5357

Merged
merged 1 commit into from Jul 12, 2018

Conversation

mistercrunch
Copy link
Member

This issue alters existing charts in undesired ways (new columns show up).

@codecov-io
Copy link

Codecov Report

Merging #5357 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5357   +/-   ##
=======================================
  Coverage   61.33%   61.33%           
=======================================
  Files         369      369           
  Lines       23489    23489           
  Branches     2714     2714           
=======================================
  Hits        14407    14407           
  Misses       9070     9070           
  Partials       12       12
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 47.32% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7158fb1...d5ee2b7. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented Jul 10, 2018

🚢

@hughhhh hughhhh self-requested a review July 10, 2018 05:50
@mistercrunch mistercrunch merged commit 0ca426a into apache:master Jul 12, 2018
@mistercrunch mistercrunch deleted the perc_met_def branch July 12, 2018 14:32
xumiao pushed a commit to xumiao/supernorm that referenced this pull request Jul 16, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels v0.26 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants