Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] should use forceV2Edit property name #5362

Merged
merged 1 commit into from Jul 9, 2018
Merged

[dashboard] should use forceV2Edit property name #5362

merged 1 commit into from Jul 9, 2018

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jul 8, 2018 •
edited

  1. should use forceV2Edit property name
  2. fix logic for show/hide save button

@williaster

@codecov-io
Copy link

codecov-io commented Jul 8, 2018 •
edited

Codecov Report

Merging #5362 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5362   +/-   ##
=======================================
  Coverage   61.31%   61.31%           
=======================================
  Files         369      369           
  Lines       23497    23497           
  Branches     2715     2715           
=======================================
  Hits        14407    14407           
  Misses       9078     9078           
  Partials       12       12
Impacted Files Coverage Δ
...rc/dashboard/deprecated/v1/components/Controls.jsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17f714...d1049a4. Read the comment docs.

williaster
williaster approved these changes Jul 8, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍

@graceguo-supercat graceguo-supercat merged commit 6b15592 into apache:master Jul 9, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Jul 9, 2018
[dashboard] should use forceV2Edit property name (apache#5362)
5acdc62 
(cherry picked from commit 6b15592)
@graceguo-supercat graceguo-supercat deleted the gg-forceV2Edit branch July 9, 2018 22:05
xumiao pushed a commit to xumiao/supernorm that referenced this pull request Jul 16, 2018
@xumiao
[dashboard] should use forceV2Edit property name (apache#5362)
eb0e337
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
@timifasubaa
[dashboard] should use forceV2Edit property name (apache#5362)
b37886e
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
@mistercrunch
[dashboard] should use forceV2Edit property name (apache#5362)
816e102 
(cherry picked from commit 6b15592)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
@mistercrunch
[dashboard] should use forceV2Edit property name (apache#5362)
1d744b8 
(cherry picked from commit 6b15592)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
@mistercrunch
[dashboard] should use forceV2Edit property name (apache#5362)
5dc6256 
(cherry picked from commit 6b15592)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
@mistercrunch
[dashboard] should use forceV2Edit property name (apache#5362)
f6722c0 
(cherry picked from commit 6b15592)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
@mistercrunch
[dashboard] should use forceV2Edit property name (apache#5362)
f9d3bfc 
(cherry picked from commit 6b15592)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
@mistercrunch
[dashboard] should use forceV2Edit property name (apache#5362)
77ba12b 
(cherry picked from commit 6b15592)
mistercrunch pushed a commit that referenced this pull request Aug 12, 2018
@mistercrunch
[dashboard] should use forceV2Edit property name (#5362)
8bad987
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
[dashboard] should use forceV2Edit property name (apache#5362)
637b559
@mistercrunch mistercrunch added 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch
[dashboard] should use forceV2Edit property name (apache#5362)
f427e54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@graceguo-supercat @codecov-io @williaster @mistercrunch