quote hive column names #5368
Merged
quote hive column names #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5368 +/- ##
=======================================
Coverage 61.31% 61.31%
=======================================
Files 369 369
Lines 23497 23497
Branches 2715 2715
=======================================
Hits 14407 14407
Misses 9078 9078
Partials 12 12
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Jul 13, 2018
timifasubaa
added a commit
to timifasubaa/incubator-superset
that referenced
this pull request
Jul 14, 2018
xumiao
pushed a commit
to xumiao/supernorm
that referenced
this pull request
Jul 16, 2018
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
timifasubaa
added a commit
to timifasubaa/incubator-superset
that referenced
this pull request
Sep 6, 2018
timifasubaa
added a commit
to timifasubaa/incubator-superset
that referenced
this pull request
Sep 10, 2018
timifasubaa
added a commit
that referenced
this pull request
Sep 11, 2018
* quote hive column names (#5368) * create db migration * use stats_logger timing * trigger build
timifasubaa
added a commit
to timifasubaa/incubator-superset
that referenced
this pull request
Sep 11, 2018
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 13, 2018
* quote hive column names (apache#5368) * create db migration * use stats_logger timing * trigger build (cherry picked from commit 9a4bba4)
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 20, 2018
(cherry picked from commit 22b7c2d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* quote hive column names (apache#5368) * create db migration * use stats_logger timing * trigger build
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* quote hive column names (apache#5368) * create db migration * use stats_logger timing * trigger build
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When columns have strange characters, not quoting them can lead to errors. THis PR quotes the column names to avoid such errors.
@john-bodley @michellethomas