Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] make MetricsControl work with DECK visualizations #5376

Merged
merged 2 commits into from
Jul 16, 2018
Merged

[bugfix] make MetricsControl work with DECK visualizations #5376

merged 2 commits into from
Jul 16, 2018

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jul 11, 2018 •
edited
Loading

  • fix "Point Size" control not displaying the metric list properly
  • fix the use of complex metrics in the new MetricsControl
  • improved the error message when spatial points cannot be decoded (the Unashable type error)

@hughhhh @betodealmeida

hughhhh
hughhhh reviewed Jul 11, 2018
View reviewed changes
superset/viz.py
@@ -2079,6 +2079,14 @@ def process_spatial_query_obj(self, key, group_by):
elif spatial.get('type') == 'geohash':
group_by += [spatial.get('geohashCol')]

@staticmethod
def parse_coordinates(s):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a unit test here?

@codecov-io
Copy link

codecov-io commented Jul 16, 2018 •
edited
Loading

Codecov Report

Merging #5376 into master will increase coverage by 0.08%.
The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5376      +/-   ##
==========================================
+ Coverage   61.34%   61.42%   +0.08%     
==========================================
  Files         373      373              
  Lines       23521    23539      +18     
  Branches     2725     2725              
==========================================
+ Hits        14429    14459      +30     
+ Misses       9079     9067      -12     
  Partials       13       13
Impacted Files Coverage Δ
superset/assets/src/explore/visTypes.js 55.55% <ø> (ø) ⬆️
superset/assets/src/logger.js 95.58% <ø> (ø) ⬆️
superset/exceptions.py 100% <100%> (ø) ⬆️
...plore/components/controls/FixedOrMetricControl.jsx 88% <100%> (ø) ⬆️
superset/viz.py 81.67% <86.36%> (+0.32%) ⬆️
superset/connectors/sqla/models.py 78.13% <0%> (+0.79%) ⬆️
superset/db_engine_specs.py 53.83% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd47587...90d92c4. Read the comment docs.

@mistercrunch
Copy link
Member Author

Addressed comments, merging

@mistercrunch mistercrunch merged commit 709f056 into apache:master Jul 16, 2018
@mistercrunch mistercrunch deleted the fix_deck_metrics branch July 16, 2018 20:42
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
@mistercrunch @timifasubaa
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
46cda54 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 26, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
3ff256e 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests

(cherry picked from commit 709f056)
(cherry picked from commit 23262ae988310ea406ff374a2ece86949be1c228)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 26, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
35c6b07 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests

(cherry picked from commit 709f056)
(cherry picked from commit 23262ae988310ea406ff374a2ece86949be1c228)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 26, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
cf4ce21 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests

(cherry picked from commit 709f056)
(cherry picked from commit 23262ae988310ea406ff374a2ece86949be1c228)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 27, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
3c8d5f1 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests

(cherry picked from commit 709f056)
(cherry picked from commit 23262ae988310ea406ff374a2ece86949be1c228)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Jul 31, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
6acd2e1 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests

(cherry picked from commit 709f056)
(cherry picked from commit 23262ae988310ea406ff374a2ece86949be1c228)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
73b2608 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests

(cherry picked from commit 709f056)
(cherry picked from commit 23262ae988310ea406ff374a2ece86949be1c228)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 3, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
8d8f1c1 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests

(cherry picked from commit 709f056)
(cherry picked from commit 23262ae988310ea406ff374a2ece86949be1c228)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
20c42b5 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests

(cherry picked from commit 709f056)
(cherry picked from commit 23262ae988310ea406ff374a2ece86949be1c228)
mistercrunch added a commit to lyft/incubator-superset that referenced this pull request Aug 4, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
d948652 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests

(cherry picked from commit 709f056)
(cherry picked from commit 23262ae988310ea406ff374a2ece86949be1c228)
mistercrunch added a commit that referenced this pull request Aug 12, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (#5376)
d7485db 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
6900c92 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests
@mistercrunch mistercrunch added 🍒 0.27.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch
[bugfix] make MetricsControl work with DECK visualizations (apache#5376)
0160e93 
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughhhh hughhhh hughhhh left review comments

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🍒 0.27.0 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mistercrunch @codecov-io @hughhhh